Skip to content

Update loading of config from a file in test_config.py #7344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2024
Merged

Update loading of config from a file in test_config.py #7344

merged 2 commits into from
Mar 18, 2024

Conversation

tolgacangoz
Copy link
Contributor

@tolgacangoz tolgacangoz commented Mar 15, 2024 •
edited
Loading

This pull request updates the loading of config from a file in the test_config.py file to remove deprecation warning.
@sayakpaul

@sayakpaul sayakpaul requested a review from yiyixuxu March 16, 2024 02:35
@yiyixuxu
Copy link
Collaborator

hi @StandardAI
why do we need this change?

@tolgacangoz
Copy link
Contributor Author

Just to remove the deprecation warning, that's all. It says it is deprecated to use from_config() for reading from a file path.

yiyixuxu
yiyixuxu approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu yiyixuxu merged commit 916d981 into huggingface:main Mar 18, 2024
@tolgacangoz
Copy link
Contributor Author

Thanks for merging!

@tolgacangoz tolgacangoz deleted the update-reading-from-path branch March 19, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiyixuxu yiyixuxu yiyixuxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tolgacangoz @yiyixuxu @sayakpaul