fix: Fixed a wrong link to supported python versions in contributing.md file
#7638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
reviewed
Apr 11, 2024
CONTRIBUTING.md
Outdated
| @@ -355,7 +355,7 @@ You will need basic `git` proficiency to be able to contribute to | |||
| manual. Type `git --help` in a shell and enjoy. If you prefer books, [Pro | |||
| Git](https://git-scm.com/book/en/v2) is a very good reference. | |||
|
|
|||
| Follow these steps to start contributing ([supported Python versions](https://github.com/huggingface/diffusers/blob/main/setup.py#L265)): | |||
| Follow these steps to start contributing ([supported Python versions](https://github.com/huggingface/diffusers/blob/main/setup.py#L270)): | |||
There was a problem hiding this comment.
Actually, this should ideally be a permalink.
There was a problem hiding this comment.
Yeah, it makes more sense. I updated the link to a permalink. Please check now. Thanks!
There was a problem hiding this comment.
It will be only needed to update this permalink when supported Python versions are changed. Make sense 👍.
tolgacangoz
approved these changes
Apr 18, 2024
sayakpaul
approved these changes
May 12, 2024
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
….md` file (#7638) * Fixed a wrong link to python versions in contributing.md file. * Updated the link to a permalink, so that it will permanently point to the specific line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a wrong link to supported Python versions in
contributing.mdfile.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Core library: