Skip to content

Conversation

fabiorigano
Copy link
Contributor

What does this PR do?

Adds an example of image masking using multiple masks for a single IP Adapter and fixes Face ID examples

Who can review?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@@ -305,15 +305,32 @@ masks = processor.preprocess([mask1, mask2], height=output_height, width=output_
</div>
</div>

When there is more than one input IP-Adapter image, load them as a list to ensure each image is assigned to a different IP-Adapter. Each of the input IP-Adapter images here correspond to the masks generated above.
When there is more than one input IP-Adapter image, you have two methods to assign images to IP Adapters: one is to load them as a list to ensure that each image is assigned to a different IP-Adapter, the other is assign them all to the same IP Adapter. Each of the input IP-Adapter images here correspond to the masks generated above.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

umm, we should always assign a list of images to the same IP Adapter instead of loading the same adapter multiple times: even though the latter would work, we don't recommend it so no need to mention it on the doc IMO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, now updated

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the update!

@yiyixuxu yiyixuxu merged commit 8e4ca1b into huggingface:main Apr 26, 2024
@fabiorigano fabiorigano deleted the ipadapterdocs branch April 27, 2024 08:42
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
* [Docs] Update image masking and face id example

* Update docs

* Fix docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants