Create custom container for doc builder #8263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
approved these changes
May 23, 2024
Comment on lines
+29
to
+43
| RUN python3.10 -m pip install --no-cache-dir --upgrade pip uv==0.1.11 && \ | ||
| python3.10 -m uv pip install --no-cache-dir \ | ||
| torch \ | ||
| torchvision \ | ||
| torchaudio \ | ||
| invisible_watermark \ | ||
| --extra-index-url https://download.pytorch.org/whl/cpu && \ | ||
| python3.10 -m uv pip install --no-cache-dir \ | ||
| accelerate \ | ||
| datasets \ | ||
| hf-doc-builder \ | ||
| huggingface-hub \ | ||
| Jinja2 \ | ||
| librosa \ | ||
| numpy \ |
There was a problem hiding this comment.
Do we need all of these for doc-builder?
There was a problem hiding this comment.
Yeah I think the autodoc imports could be affected if dependencies aren't in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Create a custom container for the doc builder workflows that allows us to control dependency versions.
We can use this custom container in our doc builder workflows to avoid issues raised here:
https://github.com/huggingface/diffusers/actions/runs/9209149805/job/25333020361?pr=8242#step:14:70
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.