Skip to content

Conversation

leszekhanusz
Copy link
Contributor

Fixes issue #846

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 14, 2022

The documentation is not available anymore as the PR was closed or merged.

@patrickvonplaten
Copy link
Contributor

cc @patil-suraj

Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! Just left a comment, we can simply this logic a bit by adding timestamps to the filepath so we get unique names each time.

@leszekhanusz leszekhanusz changed the title Dreambooth class image generation: add an underscore to filename if it already exists Dreambooth class image generation: using unique names to avoid overwriting existing image Oct 20, 2022
Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patil-suraj
Copy link
Contributor

The failing test is unrelated, merging

@patil-suraj patil-suraj merged commit 4bf675f into huggingface:main Oct 20, 2022
@leszekhanusz leszekhanusz deleted the fix_dreambooth_class_image_generation branch October 20, 2022 14:04
prathikr pushed a commit to prathikr/diffusers that referenced this pull request Oct 26, 2022
…iting existing image (huggingface#847)

* Add an underscore to filename if it already exists

* Use sha1sum hash instead of adding underscores
PhaneeshB pushed a commit to nod-ai/diffusers that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants