Fix saving text encoder weights and kohya weights in advanced dreambooth lora script #8766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
linoytsaban
reviewed
Jul 2, 2024
| @@ -2413,7 +2413,7 @@ def get_sigmas(timesteps, n_dim=4, dtype=torch.float32): | |||
| lora_state_dict = load_file(f"{args.output_dir}/pytorch_lora_weights.safetensors") | |||
| peft_state_dict = convert_all_state_dict_to_peft(lora_state_dict) | |||
| kohya_state_dict = convert_state_dict_to_kohya(peft_state_dict) | |||
| save_file(kohya_state_dict, f"{args.output_dir}/{args.output_dir}.safetensors") | |||
| save_file(kohya_state_dict, f"{args.output_dir}/kohya_lora_weights.safetensors") | |||
There was a problem hiding this comment.
maybe we can use Path(args.output_dir).name ? so it'll be -
save_file(kohya_state_dict, f"{args.output_dir}/{Path(args.output_dir).name}.safetensors")
cc @apolinario
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
…oth lora script (#8766) * update * update * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There seems to be an issue with
output_dir=../checkpoints/my-dog-modelwill result in the following line creating a path like'../checkpoints/my-dog-model/../checkpoints/my-dog-model.safetensors'diffusers/examples/advanced_diffusion_training/train_dreambooth_lora_sd15_advanced.py
Line 1984 in 610a71d
I've changed this to save the kohya weight as
args.output_dir/kohya_lora_weights.safetensorsbut I'm open to any better naming.train_text_encoderargument, I believe there is a missingelsestatement resulting in an ValueError always being raised.Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.