[docs] Fix xDiT doc image damage #9655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
approved these changes
Oct 12, 2024
There was a problem hiding this comment.
Thanks! You could consider hosting this images in a dataset repository on the Hugging Face (perhaps through an org called xDiT) and use the links from there.
Here is an example of such a repository:
https://huggingface.co/datasets/huggingface/documentation-images
|
Great advice! I will try it. Thank you. |
Eigensystem
changed the title
Eigensystem
changed the title
sayakpaul
approved these changes
Oct 12, 2024
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* docs: fix xDiT doc image damage * doc: move xdit images to hf dataset --------- Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixed xDiT document image damage
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@stevhliu and @sayakpaul