Skip to content

Update image_processor.py #9795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Update image_processor.py #9795

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f27870c
Update image_processor.py
John6666cat Oct 29, 2024
2598df6
Merge branch 'main' into patch-1
sayakpaul Nov 1, 2024
bc20fba
Merge branch 'main' into patch-1
John6666cat Nov 13, 2024
359ff9e
Update image_processor.py
John6666cat Nov 13, 2024
5afb935
Merge branch 'main' into patch-1
sayakpaul Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/diffusers/image_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def is_valid_image(image) -> bool:
`bool`:
`True` if the input is a valid image, `False` otherwise.
"""
return isinstance(image, PIL.Image.Image) or isinstance(image, (np.ndarray, torch.Tensor)) and image.ndim in (2, 3)
Copy link
Collaborator

@yiyixuxu yiyixuxu Dec 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but if it is a PIL.Image, isinstance(image, PIL.Image.Image) will evaluate to True and whole thing will just return True without check the dimension , no?
can you show an example that this fails?

isinstance(image, PIL.Image.Image) or isinstance(image, (np.ndarray, torch.Tensor)) and image.ndim in (2, 3)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's true... I tried it locally and you were right.
I seem to have misunderstood the cause and made a false assumption. I will withdraw the PR. I apologize.

return (isinstance(image, (np.ndarray, torch.Tensor)) and image.ndim in (2, 3)) or isinstance(image, PIL.Image.Image)


def is_valid_image_imagelist(images):
Expand Down