Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tasks] Spec: follow-up to #449 #463

Open
6 of 11 tasks
SBrandeis opened this issue Jan 26, 2024 · 2 comments
Open
6 of 11 tasks

[Tasks] Spec: follow-up to #449 #463

SBrandeis opened this issue Jan 26, 2024 · 2 comments
Assignees
Labels
tasks @huggingface/tasks related

Comments

@SBrandeis
Copy link
Contributor

SBrandeis commented Jan 26, 2024

TODO

This issue lists the remaining tasks following #449

"Bigger" changes:

  • Rename feature-extraction to text-embedding
  • Unify text-generation and text2text-generation
@SBrandeis SBrandeis added the tasks @huggingface/tasks related label Jan 26, 2024
@SBrandeis SBrandeis self-assigned this Jan 26, 2024
@Wauplin
Copy link
Contributor

Wauplin commented Jan 26, 2024

(some comments I had)

  • in "common parameters" I would rename GenerationParameters to TextGenerationParameters or TextGenerationCommonParameters (to differentiate from other image generation (and audio, video, etc?))

"Bigger changes":

  • add constraints to the values (especially text_generation and text_to_image float/integer parameters). Constraints might not be reflected in all generated code but will still be useful to document

@philschmid
Copy link
Member

philschmid commented Feb 1, 2024

I was looking into the first added schema and was a bit surprised that they do not match the API schema from inference Endpoints or the Inference API. I thought we wanted to create an external schema that can be used for code generation and other validation to make sure all libraries, API, etc have the same types.

When i looked into it i saw that the main input is called "data" and not "inputs". I also noticed that the "parameters" are "camelCase" and not "snake_case" (in the definitions), Some definitions, e.g. "text-generation" are only for TGI and not for the text-generation pipeline.

What's the plan here? I don't think we should maintain definitions that need to be adjusted again to work with our products. I thought we start with an API first approach to then integrate into the libraries.

SBrandeis added a commit that referenced this issue Feb 8, 2024
Part of #463 

Rename `data` to `inputs` to conform existing APIs format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks @huggingface/tasks related
Projects
None yet
Development

No branches or pull requests

3 participants