Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Changes to build inference types #464

Merged
merged 5 commits into from
Feb 5, 2024
Merged

👷 Changes to build inference types #464

merged 5 commits into from
Feb 5, 2024

Conversation

coyotte508
Copy link
Member

@coyotte508 coyotte508 commented Jan 29, 2024

Follow up to #449

Review with whitespaces off

@coyotte508 coyotte508 marked this pull request as draft January 29, 2024 18:06
@coyotte508 coyotte508 marked this pull request as ready for review January 29, 2024 20:09
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@coyotte508
Copy link
Member Author

Waiting a bit for @SBrandeis input :)

Copy link
Contributor

@SBrandeis SBrandeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@@ -139,54 +141,44 @@ async function postProcessOutput(path2generated: string, outputSpec: Record<stri
return;
}

async function main() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@coyotte508 coyotte508 merged commit 79ae82f into main Feb 5, 2024
3 checks passed
@coyotte508 coyotte508 deleted the task-build branch February 5, 2024 18:07
@SBrandeis SBrandeis mentioned this pull request Feb 7, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants