[GGUF] buildGgufHeader support streaming blobs (WebBlob/XetBlob) #1762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: buildGgufHeader #1759 was failing with RangeError: Offset is outside the bounds of the DataView when using streaming blobs (WebBlob/XetBlob) because it tried to slice them without awaiting the data.
Solution: Added await originalTensorInfoBlob.arrayBuffer() to properly fetch tensor info data from streaming blobs before combining with new header.
Why needed: This enables efficient GGUF metadata editing with SplicedBlob and streaming downloads, avoiding the need to download entire large files upfront. Critical for the optimized commit workflow in hub package.