xet: Update chunk indexes in the chunkCache after deduplication #1780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the chunk indexes in the chunkCache after deduplication to match the new xorb chunks. They were already updated in the passed `chunkMetadata` array, but not in the chunkCache. Which meant that if the chunks were requested again eg (due to uploading another file with shared content in the same `uploadShards`) the chunk indexes provided would be incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the chunk indexes in the chunkCache after deduplication to match the new xorb chunks.
The problem happens if a previous chunk in the xorb is removed during backtrack deduplication. Then the chunk indexes for the following chunks in teh xorb were updated in the passed
chunkMetadataarray, but not in the chunkCache.Which meant that if the chunks were requested again eg (due to uploading another file with shared content in the same
uploadShardscall) the chunk indexes provided would be incorrect.cc @assafvayner @mishig25 for viz
Follow up #1771 and #1779
Also improved the debug/replay script to support multiple files upload, and added a test