Embed compiled metal kernels into binary #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricLBuehler
force-pushed
the
embedded_metallib
branch
from
9fc3ceb to
7973574
Compare
danieldk
reviewed
Jul 17, 2025
examples/relu/relu_metal/relu.mm
Outdated
| std::string moduleDir = getModuleDirectory(); | ||
| std::string metallibPath = moduleDir + "/" + METALLIB_PATH; | ||
| // Load the embedded Metal library from memory | ||
| dispatch_data_t libraryData = dispatch_data_create( |
There was a problem hiding this comment.
Maybe we could even make this friendlier for Metal kernels by generating/providing a header that does this for you? So something like
id<MTLLibrary> customKernelLibrary = [ourFunction args];
(Not sure what the exact syntax should look like, since I'm not familiar with ObjectiveC++).
Not 100% sure if this is useful, but maybe worth experimenting with?
It's nice to see the path handling go away!
There was a problem hiding this comment.
Nice idea! Added a function to deal with this, it's defined in the header with metallib_to_header.py and accessed with EMBEDDED_METALLIB_NAMESPACE.
Let me know what you think about this solution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This embeds the
.metallibfile into the main.so, removing the difference when loading a CUDA vs Metal kenrnel. It is a breaking change to the metal kernel compilation strategy.