-
Notifications
You must be signed in to change notification settings - Fork 23
[Merged through #155] Add support for npu kernelize #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@danieldk Hi, we have added support for npu to the kernels. This pr is ready for review. Thanks! |
Thanks for the PR! Are you also planning to add support to kernel-builder (since it's the best way to build compliant kernels)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bunch of suggestions, also some questions about compatibility between versions, etc.
3d5866a
to
357d531
Compare
Thanks for asking! Yes, we are actively working on adding npu support to |
166b775
to
6a58157
Compare
Co-authored-by: Daniël de Kok <me@danieldk.eu>
On NPU: pytest -v ./kernels/tests/
|
@danieldk |
Nice! 🚀 I'll try to do another review pass today or Monday. |
Supplement test by transformers
script:
output:
|
This change add support for Huawei Ascend NPUs. This is #146 with some formatting/typing fixes. Co-authored-by: zheliuyu <15750543867@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! I have merged this through #155 (adds some formatting/typing fixes to pass CI).
What does this PR do?
Add support for npu kernelize.
Checklist Before Starting
Test
On GPU: pytest -v test_layer.py
On NPU: pytest -v test_layer.py