reduces cli args redundancy #932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clefourrier
reviewed
Aug 21, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
clefourrier
approved these changes
Aug 25, 2025
clefourrier
reviewed
Aug 25, 2025
clefourrier
reviewed
Aug 26, 2025
src/lighteval/cli_args.py
Outdated
| ReasoningTags = Annotated[ | ||
| str, | ||
| Option( | ||
| help="List of reasoning tag pairs to remove from responses, formatted as a Python list of tuples.", |
There was a problem hiding this comment.
you should indicate what the default will be in the doc btw
There was a problem hiding this comment.
It added by typer automatically
There was a problem hiding this comment.
Nice!
How does it interact with the docstrings of the doc page?
There was a problem hiding this comment.
it does not sync with the docs, but the behaviour did not change so the docs are the same.
…gface/lighteval into nathan-reduce-cli-args-redundancy
NathanHB
added a commit
that referenced
this pull request
Sep 19, 2025
* reduces cli args redundancy * fix typing * reasoning tags do not need to default to None to then be attributed to actual default * fix typing for dataclass * better docs for cli args * fix reasoning tags parsing * update from suggestion * styling * styling * styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.