Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of OVModelForVision2Seq class #634

Merged
merged 8 commits into from
Mar 29, 2024
Merged

Add support of OVModelForVision2Seq class #634

merged 8 commits into from
Mar 29, 2024

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Mar 27, 2024

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@AlexKoff88 AlexKoff88 requested a review from echarlaix March 27, 2024 14:49
@AlexKoff88 AlexKoff88 assigned AlexKoff88 and echarlaix and unassigned AlexKoff88 Mar 27, 2024
@eaidova @AlexKoff88
Apply suggestions from code review
4d88b96 
Co-authored-by: Alexander Kozlov <alexander.kozlov@intel.com>
@eaidova eaidova requested a review from AlexKoff88 March 27, 2024 15:35
echarlaix
echarlaix approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the addition @eaidova !

optimum/intel/__init__.py Show resolved Hide resolved
tests/openvino/test_modeling.py Show resolved Hide resolved
echarlaix
echarlaix reviewed Mar 28, 2024
View reviewed changes
tests/openvino/test_modeling.py Outdated Show resolved Hide resolved
optimum/intel/__init__.py Show resolved Hide resolved
@echarlaix
Copy link
Collaborator

failing tests unrelated so merging

@echarlaix echarlaix merged commit bf9fc02 into huggingface:main Mar 29, 2024
8 of 10 checks passed
@echarlaix echarlaix mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarlaix echarlaix echarlaix approved these changes

@AlexKoff88 AlexKoff88 AlexKoff88 approved these changes

Assignees

@echarlaix echarlaix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eaidova @HuggingFaceDocBuilderDev @echarlaix @AlexKoff88