Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OV configurations alignment #787

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

KodiaqQ
Copy link
Contributor

@KodiaqQ KodiaqQ commented Jun 27, 2024

  • Updated OV configurations to align with openvino.genai nncf_utils.py.

@KodiaqQ
Copy link
Contributor Author

KodiaqQ commented Jun 27, 2024

cc @AlexKoff88, @MaximProshin

"ratio": 0.8,
"dataset": "wikitext2",
"awq": True,
},
"stablelm-epoch-3b-preview": {"bits": 4, "sym": True, "group_size": 64, "ratio": 0.8},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this line be removed, it looks like it is accidentally copied with wrong naming format?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. Thanks!

@KodiaqQ KodiaqQ requested a review from eaidova June 28, 2024 06:51
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@MaximProshin
Copy link
Contributor

@KodiaqQ , I still see some misalignment with genai. In genai we have 28 models, but only 26 here. Can you explain it?

@KodiaqQ
Copy link
Contributor Author

KodiaqQ commented Jun 28, 2024

@KodiaqQ , I still see some misalignment with genai. In genai we have 28 models, but only 26 here. Can you explain it?

As was noticed, the stablelm-epoch-3b-preview and llama-7b configurations are not applicable anymore, so I removed them.
Maybe @AlexKoff88 can confirm that as we discussed.

"sym": True,
"group_size": 64,
"ratio": 0.8,
"dataset": "wikitext2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a chance that using a specific dataset in the default configs causes better accuracy when evaluating on wikitext, but worse for actual use-cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is possible.
But this is only alignment with the default state from here openvino.genai, configurations aren't new.
cc @AlexKoff88

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's skip it here. This task is not to find better configs but rather align optimum-intel configs with ones are currently used in the OV validation which will also switch to optimum-intel. Without it, we can't switch.

@MaximProshin
Copy link
Contributor

@echarlaix , can you please help to merge it?

@echarlaix echarlaix merged commit eeb1df0 into huggingface:main Jul 1, 2024
11 of 16 checks passed
echarlaix pushed a commit that referenced this pull request Jul 8, 2024
* Align with genai

* Added stable-code-3b

* Change order

* Update configuration.py
@KodiaqQ KodiaqQ deleted the nm/configurations_alignment branch August 12, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants