Consolidate TensorUtils into Generation and reorganize targets
#244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
force-pushed
the
mattt/consolidate-tensorutils
branch
from
4a856a9 to
d77f66f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TensorUtilscontains a handful of utilities for working with Core ML types, along with some math functions that wrap Accelerate APIs. These are used exclusively by theGenerationmodule, so it makes sense to put them there instead of declaring them in a separate module.The one exception I found was
Weights&Safetensors. I decided to move that underModels, since that seemed to be a better home for it (but I'm very open to alternative suggestions).In the process of doing that, this PR also reorganized targets so that each library target (exported or not) has a corresponding test target (e.g.,
Models->ModelsTests).These changes are purely for our own benefit, since none of these targets are exported by / products of the package. So this is entirely motivated by my own preference for 1:1 correspondence between library and test target, and a vague dispreference for "Utils" modules.