Skip to content

Set force online mode in specific networked tests #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set force online mode in specific networked tests #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Tests/ModelsTests/WeightsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ struct WeightsTests {
@Test("Load weights from file URL")
func loadWeightsFromFileURL() async throws {
let repo = "google/bert_uncased_L-2_H-128_A-2"
let modelDir = try await hubApi.snapshot(from: repo, matching: ["config.json", "model.safetensors"])
let onlineHubApi = HubApi(downloadBase: downloadDestination, useOfflineMode: false)
let modelDir = try await onlineHubApi.snapshot(from: repo, matching: ["config.json", "model.safetensors"])

let files = try FileManager.default.contentsOfDirectory(at: modelDir, includingPropertiesForKeys: [.isReadableKey])
#expect(files.contains(where: { $0.lastPathComponent == "config.json" }))
Expand Down
8 changes: 4 additions & 4 deletions Tests/TokenizersTests/FactoryTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ import Hub
import Testing
import Tokenizers

private func makeHubApi() -> (api: HubApi, downloadDestination: URL) {
private func makeHubApi(useOfflineMode: Bool? = nil) -> (api: HubApi, downloadDestination: URL) {
let base = FileManager.default.urls(for: .cachesDirectory, in: .userDomainMask).first!
let destination = base.appending(component: "huggingface-tests-\(UUID().uuidString)")
return (HubApi(downloadBase: destination), destination)
return (HubApi(downloadBase: destination, useOfflineMode: useOfflineMode), destination)
}

@Suite("Factory")
Expand All @@ -40,7 +40,7 @@ struct FactoryTests {

@Test
func fromModelFolder() async throws {
let (hubApi, downloadDestination) = makeHubApi()
let (hubApi, downloadDestination) = makeHubApi(useOfflineMode: false)
defer { try? FileManager.default.removeItem(at: downloadDestination) }

let filesToDownload = ["config.json", "tokenizer_config.json", "tokenizer.json"]
Expand All @@ -54,7 +54,7 @@ struct FactoryTests {

@Test
func whisperFromModelFolder() async throws {
let (hubApi, downloadDestination) = makeHubApi()
let (hubApi, downloadDestination) = makeHubApi(useOfflineMode: false)
defer { try? FileManager.default.removeItem(at: downloadDestination) }

let filesToDownload = ["config.json", "tokenizer_config.json", "tokenizer.json"]
Expand Down
2 changes: 1 addition & 1 deletion Tests/TokenizersTests/TokenizerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ struct TokenizerTests {
return base.appending(component: "hf-local-pretrained-tests-downloads")
}()

let hubApi = HubApi(downloadBase: downloadDestination)
let hubApi = HubApi(downloadBase: downloadDestination, useOfflineMode: false)
let downloadedTo = try await hubApi.snapshot(from: "pcuenq/gemma-tokenizer")

let tokenizerOpt = try await AutoTokenizer.from(modelFolder: downloadedTo) as? PreTrainedTokenizer
Expand Down