Fix build on x86_64 #276
Merged
Fix build on x86_64 #276
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix #275 |
mattt
approved these changes
Sep 29, 2025
pcuenca
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a targeted fix to the conditional compilation logic for attention mask handling in the
LanguageModelWithStatefulKVCacheclass. The change ensures that the correct environment check is used for macOS and Mac Catalyst on x86_64 architecture.macCatalystwith the propertargetEnvironment(macCatalyst)in the#ifdirective, ensuring accurate platform detection for attention mask logic inLanguageModelWithStatefulKVCache.