Skip to content

Conversation

mattt
Copy link
Collaborator

@mattt mattt commented Sep 29, 2025

CI has been failing on recent PRs, like in this run.

Sources/Models/LanguageModel.swift:132:20: warning: [DontRepeatTypeInStaticProperties] remove the suffix 'Keys' from the name of the variable 'presentKeys'

However, this linting failure can't be resolved by any changes in the PR branch, including fixing the issue and disabling the check outright.

I noticed in the logs for action/checkout, that it's fetching origin/main, which is currently a2e184d.

Fetching the repository
  /opt/homebrew/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin +a2e184dddb4757bc943e77fbe99ac6786c53f0b2:refs/remotes/origin/main
  From https://github.com/huggingface/swift-transformers
   * [new ref]         a2e184dddb4757bc943e77fbe99ac6786c53f0b2 -> origin/main

This PR updates the lint job to use the same checkout pattern as the shared workflow for testing.

@mattt
Copy link
Collaborator Author

mattt commented Sep 29, 2025

CI continues to use the workflow file in main which checks out HEAD of main, so there's no way to get lint job to pass. We'll just have to YOLO merge and hope for the best 🤞

@mattt mattt merged commit 7422a76 into main Sep 29, 2025
1 of 2 checks passed
@mattt mattt deleted the mattt/fix-ci-lint branch September 29, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant