Skip to content

Conversation

etiennebonnafoux
Copy link
Contributor

What does this PR do?

Add the case where a torch.tensor with one element is log on Mlflow. For now it only accept float and int.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@amyeroberts

Add the case where a tensor with one element is log with Mlflow
Copy link
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! Just a small suggestion

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@etiennebonnafoux
Copy link
Contributor Author

Sorry but what should I do to pass check_code_quality and setup_and_quality test ? this is my first PR

@amyeroberts
Copy link
Contributor

@etiennebonnafoux Running make fixup and pushing the changes should resolve this. There's more info in the contributing guideline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants