Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] fix run_generation.py to work with batch_size > 1 #1333

Merged
merged 2 commits into from
Oct 31, 2019
Merged

[FIX] fix run_generation.py to work with batch_size > 1 #1333

merged 2 commits into from
Oct 31, 2019

Conversation

mataney
Copy link
Contributor

@mataney mataney commented Sep 25, 2019

I expended the top_k_top_p_filtering function, and by that therun_generation.py script to work with num_samples > 1.

This can be expended by scattering the sorted tensors.
First pull request in this repository, so let me know if I need to do anything else :)

Cheers, Matan.

@mataney
Copy link
Contributor Author

mataney commented Oct 23, 2019

@thomwolf
I created this PR to deal with the top p generations.
Should I have opened an issue first to check if it is needed?
Should I deal with the conflicts?

Cheers.

@julien-c julien-c merged commit 3c1b6f5 into huggingface:master Oct 31, 2019
@julien-c
Copy link
Member

Hi @mataney, thanks.

This was rebased, fixed by f96ce1c, and merged to master by 2a5663c.

Check that everything looks good on your side if you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants