Fix gather for TPU #13813
Merged
Fix gather for TPU #13813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing it - sorry should have tested on TPU as well :-/ |
|
No worries! |
stas00
pushed a commit
to stas00/transformers
that referenced
this pull request
Oct 12, 2021
lapisfluvialis
pushed a commit
to lapisfluvialis/transformers
that referenced
this pull request
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes #13798, which is cause by the gather of trainer loss, a 0d-tensor. The code does not add one dimension to those to concatenate properly, resulting in the error.