Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trainer] Add optional communication backends for torch.distributed when using GPU #22247

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

heya5
Copy link
Contributor

@heya5 heya5 commented Mar 18, 2023

What does this PR do?

Add optional backends for torch.distributed when using GPU.
I want to use other communication backends according the pytorch_distribution_tutorial, but I found Trainer only uses nccl when self.no_cuda is False
.
Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@heya5 heya5 changed the title Update training_args.py Add optional communication backends for torch.distributed when using GPU Mar 18, 2023
@heya5 heya5 changed the title Add optional communication backends for torch.distributed when using GPU [Trainer] Add optional communication backends for torch.distributed when using GPU Mar 18, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 18, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contibution!

@sgugger sgugger merged commit cf0af9a into huggingface:main Mar 20, 2023
raghavanone pushed a commit to raghavanone/transformers that referenced this pull request Apr 5, 2023
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants