Install accelerete@main in PyTorch Past CI jobs.
#22963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Apr 24, 2023
| if: inputs.framework == 'pytorch' | ||
| working-directory: /transformers | ||
| run: | | ||
| python3 -m pip install --no-cache-dir git+https://github.com/huggingface/accelerate@main#egg=accelerate |
There was a problem hiding this comment.
need this to be installed in CI jobs, not in Past CI docker images. See PR description.
ydshieh
commented
Apr 24, 2023
| @@ -39,6 +38,10 @@ RUN $INSTALL_CMD | |||
|
|
|||
| RUN [ "$FRAMEWORK" != "pytorch" ] && echo "`deepspeed-testing` installation is skipped" || python3 -m pip install --no-cache-dir ./transformers[deepspeed-testing] | |||
|
|
|||
| # Remove `accelerate`: it requires `torch`, and this causes import issues for TF-only testing | |||
| # We will install `accelerate@main` in Past CI workflow file | |||
| RUN python3 -m pip uninstall -y accelerate | |||
There was a problem hiding this comment.
Installed in Past CI PyTorch runs.
|
The documentation is not available anymore as the PR was closed or merged. |
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
fix Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
fix Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Install
accelerete@mainin PyTorch Past CI jobs.Context
In ##22393, we added back
deepspeedin Past CI docker image. Later in #22859, we decide to useaccelerate@main, but I forgot to apply the same change in Past CI docker file, as I mistakenly thought Past CI doesn't useaccelerate.[deepspeed-testing](installed in Past CI docker) includesaccelerate, and we want it to beaccelerate@main.acclerateit in the docker image, as for the TF Past CI, it will break somethingaccelerate requires torch, and this causes import issues for TF-only testing