Fix ConvNext V2 parameter naming issue #23122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
May 3, 2023
Comment on lines
+102
to
+105
| if "gamma" in name: | ||
| name = name.replace("gamma", "weight") | ||
| if "beta" in name: | ||
| name = name.replace("beta", "bias") |
There was a problem hiding this comment.
You don't need to do it since from_pretrained will do it anyway. But it doesn't hurt I guess 😅
There was a problem hiding this comment.
Ah true, I renamed them differently at first and then switched to weight and bias to avoid updating the checkpoints
amyeroberts
approved these changes
May 3, 2023
alaradirik
changed the title
qywu
pushed a commit
to qywu/transformers
that referenced
this pull request
May 3, 2023
Fixes the parameter naming issue in ConvNextV2GRN module
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
Fixes the parameter naming issue in ConvNextV2GRN module
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
Fixes the parameter naming issue in ConvNextV2GRN module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Renames gamma and beta parameters of the
ConvNextV2GRNmodule, which caused thesave_pretrainedmethod to rename these parameters to weight and bias.Existing checkpoints on the hub can be loaded without any warnings once the PR is merged.
Fixes #23090
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.