Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token pass #24862

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Fix token pass #24862

merged 2 commits into from
Jul 17, 2023

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Jul 17, 2023

What does this PR do?

The token passed along in PreTrainedTokenizerBase.from_pretrained is passed along twice at the end: one time in the kwargs and one time as use_auth_token. This caused the speech examples to fail.

@sgugger sgugger requested a review from LysandreJik July 17, 2023 17:02
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgugger sgugger merged commit 49eb357 into main Jul 17, 2023
@sgugger sgugger deleted the fix_token_pass branch July 17, 2023 17:27
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* Fix how token is passed along in from_pretrained for tokenizers

* It's actually not necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants