Add input_embeds functionality to gpt_neo Causal LM #25659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(CI can be fixed by running |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Just did this! |
ArthurZucker
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Thanks for the fix!
cc @ydshieh do you think it makes sense to add a common test for this? (small configs, nlp models, just test that we can use inputs_enmbeds for generation if past_key_values for most models, this way people add this automatically) ?
Comment on lines
+707
to
+709
| model_inputs.update( | ||
| { | ||
| "input_ids": input_ids, |
There was a problem hiding this comment.
Suggested change
| model_inputs.update( | |
| { | |
| "input_ids": input_ids, | |
| model_inputs.update( | |
| { |
gaasher
added a commit
to gaasher/transformers
that referenced
this pull request
Aug 22, 2023
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
* Updated gpt_neo causalLM to support using input embeddings for generation * added indentation * Did make fixup
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
* Updated gpt_neo causalLM to support using input embeddings for generation * added indentation * Did make fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on #21405, #21889, and #22916 by @gante to GPTNeoCausalLM models, which allows these models to accept input_embeds when generating.
Who can review?
@gante @sgugger