Consider disallowing `allowMultipleArguments`

[mikeselander]

In WordPress/WordPress-Coding-Standards@bb8a486 WPCS disallowed multiple arguments on a single line when using a multi-line function signature. I restored the default behavior to avoid throwing a bunch of new flags without wider discussion among the team.

So, the question now is whether or not we should follow WPCS' lead in disallowing this behavior or continue on as we have with allowing it.

Ref: #127

[rmccue]

Can you clarify what exactly this rule is? 🤔

[mikeselander]

The rule is PEAR.Functions.FunctionCallSignature.MultipleArguments.

Only one argument is allowed per line in a multi-line function call

See: https://github.com/squizlabs/PHP_CodeSniffer/blob/bff45d96700e97711b49c221377cc238be498b16/src/Standards/PEAR/Sniffs/Functions/FunctionCallSignatureSniff.php#L554-L576

[rmccue]

Right, but specifically, what would this affect? e.g. does it affect the following:

do_something( [
    'foo' => 'bar',
] );

Or

do_something( 'foo', [
    'foo' => 'bar',
] );

Both of those are relatively common patterns in our code.

[mikeselander]

Well, for example the following from our tests is flagged and would be disallowed. Your second example would definitely get flagged, I think (have not yet tested) that your first example would pass as there is only one argument.

coding-standards/tests/fixtures/pass/use-order.php

Lines 38 to 40 in f6d6e08

	add_action( 'init', function () use ( $foo ) {
	return new Zztop( $foo + 1 );
	}, 1000 );

This is a very common pattern in our code, which is why I clawed it back in #127.

[kadamwhite]

While this is in principle a good idea, getting the behaviour that @rmccue , @mikeselander and I agreed we would want might have required writing a custom rule, which feels too complex.