Restore allowMultipleArguments
#127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadamwhite
approved these changes
Mar 25, 2019
There was a problem hiding this comment.
I think conceptually I'm in favor of the change they made, and aside from the tests for this repository a quick smoke-test of HM project code indicates we follow this rule pretty consistently. That said, +1 on rolling it back locally until we can make that switch more mindfully.
|
Agreed, I don't have a problem with their philosophy. I'm more afraid of this throwing a bunch of new flags all of a sudden for developers without greater discussion of the topic. I'll open an Issues for this. |
joehoyle
reviewed
Mar 26, 2019
rmccue
previously requested changes
Mar 26, 2019
|
@rmccue I've adjusted the spaces - any more thoughts on this change? |
kadamwhite
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In WPCS 1.1.0, the
allowMultipleArgumentsproperty fromPEAR.Functions.FunctionCallSignaturewas disallowed, causing our tests to fail and existing behavior to be altered.I re-allowed this to restore expected behavior and updated Composer to more explicitly show which version we are on (
^1.0.0was already giving us 1.2.1, just without the explicit declaration).We can easily turn this back off if we decide to alter the behavior in the future. I believe this to be the only "breaking"/expectation-changing behavior from WPCS 1.0.0 -> 1.2.0.