-
Notifications
You must be signed in to change notification settings - Fork 313
feat: support custom otel collector config (BETA) #1074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 8a04890 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@@ -0,0 +1,49 @@ | |||
#!/bin/sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
running the log rotator script along with the main otelcol process to rotate agent.log
file since its size grows rapidly
Stably Runner - Test Suite - 'Smoke Test'Test Suite Run Result: 🟢 Success (4/4 tests passed) [dashboard] This comment was generated from stably-runner-action |
}, | ||
}, | ||
clickhouse: { | ||
endpoint: '${env:CLICKHOUSE_ENDPOINT}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a lot of cases like this. Seems like we are telling the Otel collector to look at it's own env vars to find these values. But with a deployment like this, the opampController.ts could just fill these out and provide the Otel Collector config with fully formed config. Which is preferable? It's almost like a templating problem, should the opampController provide a template or a fully rendered config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the OSS setup, it makes more sense to provide the CH credentials on the otel collector side, which also has a smaller surface area from a security perspective. We also want to be cautious about changes that affect the Helm chart. This PR is purely a refactor and does not introduce any breaking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, all seems well
plus the fix to reduce bloat in opamp agent logs
Users should be able to mount the custom otel collector config file and add/overrider receivers, processors and exporters
For example:
This will add a new
hostmetrics
receiver +metrics/hostmetrics
pipeline and update existingbatch
+memory_limiter
processorsWARNING: This feature is still in beta, and future updates may change how it works, potentially affecting compatibility
Ref: HDX-1865