Skip to content

Members of enums are imported #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kyledewey
Copy link
Contributor

This push breaks master. This pull request makes everything (including tests) compile again.

@reem
Copy link
Contributor

reem commented Nov 19, 2014

@seanmonstar Do we want to do this or would we like to refer to variants by their new namespace names throughout hyper?

@seanmonstar
Copy link
Member

@reem not sure what you mean. It looks like this refers to variants like
'StatusCode::Ok'.

On Tue, Nov 18, 2014, 10:44 PM Jonathan Reem notifications@github.com
wrote:

@seanmonstar https://github.com/seanmonstar Do we want to do this or
would we like to refer to variants by their new namespace names throughout
hyper?


Reply to this email directly or view it on GitHub
#123 (comment).

@seanmonstar seanmonstar mentioned this pull request Nov 19, 2014
@emberian
Copy link
Contributor

ISTM like the method module no longer needs to exist, since the variants can legitimately just be Method::Get.

It'd be nice to get any fix merged, though, my projects are broken right now.

@jgillich
Copy link
Contributor

@cmr (Nevermind, I guess you already knew that) You can checkout @kyledewey's branch and use it as an overwrite in the cargo config (paths): http://doc.crates.io/config.html

But I agree, I would also like to see my Travis tests to pass from time to time. 😉

@seanmonstar I think there is a single case of glob usage kyledewey@b530eb5#diff-c32e97574dbd96ceca6dcb3e8b7376bfR8

Do you want me to change it? Unless @kyledewey wants to do it himself, of course.

@kyledewey
Copy link
Contributor Author

I won't have the chance to change it anytime soon; I'm fine if someone else does. I agree that using globs for enum members seems like it would lead to some surprise with respect to the Rust change.

@seanmonstar
Copy link
Member

Yea, I'd rather not use the globs feature.

We don't need to do away with the modules, since it's nice to contain them in separate files, but perhaps it makes sense to re-export the enums in lib.rs. such as pub use method::Method;.

@jgillich jgillich mentioned this pull request Nov 19, 2014
@jgillich
Copy link
Contributor

^ PR is up.

@reem
Copy link
Contributor

reem commented Nov 19, 2014

Closed in favor of #127.

@reem reem closed this Nov 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants