Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespaced enums #127

Merged
merged 3 commits into from Nov 19, 2014
Merged

namespaced enums #127

merged 3 commits into from Nov 19, 2014

Conversation

jgillich
Copy link
Contributor

ref #123

Tests pass with #![allow(deprecated)], I am not sure how to fix that one.

@reem
Copy link
Contributor

reem commented Nov 19, 2014

What's the deprecation warning coming from?

@jgillich
Copy link
Contributor Author

HashMap::find_equiv: http://doc.rust-lang.org/std/collections/struct.HashMap.html#method.find_equiv

src/header/mod.rs:148:19: 148:53 error: use of deprecated item: use get and BorrowFrom instead, #[deny(deprecated)] on by default
src/header/mod.rs:148         self.data.find_equiv(&CaseInsensitive(name)).and_then(|item| {

@seanmonstar
Copy link
Member

looks good to me. rust nightlies broke several things, I think fixing find_equiv can be a separate PR.

@reem
Copy link
Contributor

reem commented Nov 19, 2014

Oh god cargo is breaking now. retrying.

@reem
Copy link
Contributor

reem commented Nov 19, 2014

Ok, the only error here is from find_equiv, so I am merging with hopes to fix that in another PR.

reem added a commit that referenced this pull request Nov 19, 2014
@reem reem merged commit 5e92d82 into hyperium:master Nov 19, 2014
@jgillich jgillich deleted the enum branch November 19, 2014 22:49
@seanmonstar seanmonstar mentioned this pull request Nov 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants