Factor out EntityTag from Etag header #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with your Pull Request
Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
hugoduncan
force-pushed
the
feature/factor-entity-tag
branch
from
7fef4c4 to
cbfb58b
Compare
| /// The opaque string in between the DQUOTEs | ||
| pub tag: String | ||
| } | ||
| pub struct Etag(pub EntityTag); |
There was a problem hiding this comment.
With a newtype like this, could you also add deref!(Etag => EntityTag)?
|
What's another example of a header needing an entity tag? |
|
If-Match and If-None-Match. |
|
Fair enough! I'm sold. Just the deref nit and I'll merge. On Fri, Feb 6, 2015, 2:27 PM Josh Matthews notifications@github.com wrote:
|
|
Would you like these squashed to a single commit? |
|
Yes please! |
Allow use of EntityTag in other headers that use entity tags. BREAKING CHANGE: for any consumers of the Etag header, since the entity tag is now in a tuple.
hugoduncan
force-pushed
the
feature/factor-entity-tag
branch
from
c4744eb to
28fd5c8
Compare
seanmonstar
added a commit
that referenced
this pull request
Feb 7, 2015
Factor out EntityTag from Etag header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow use of EntityTag in other headers that use entity tags.