Skip to content

Conversation

@tjaneczko
Copy link
Collaborator

This PR adds the following to the gh-release CLI:

  • A --noconfirm flag for skipping the confirmation prompt (modeled after Arch Linux' pacman's --noconfirm)
  • The ability to read an authentication token from the GH_RELEASE_GITHUB_API_TOKEN environment variable

These two features combined allow for gh-release to be used in continuous-delivery systems (like Jenkins) where user interaction is not possible. It also allows these systems to work with multiple GitHub APIs (i.e. github.com and a self-hosted Enterprise GitHub) by simply swapping out the token environment variable.

Resolves #75

@ungoldman
Copy link
Owner

Hi @tjaneczko, thanks for this PR!

Only one comment: I'm more a fan of the -y or --yes convention mentioned in the original issue (#75), which is a common convention for npm and node userland, as opposed to noconfirm, which sounds like something more specific to Arch Linux's pacman package manager.

Otherwise looks great!

Are you willing to update to use yes with a y alias instead of noconfirm?

@tjaneczko
Copy link
Collaborator Author

Sure thing! Will switch back to using --yes with a y alias. Thanks for the review!

@tjaneczko
Copy link
Collaborator Author

@ungoldman should be all set for another look!

@ungoldman ungoldman merged commit 54a24e9 into master Sep 4, 2018
@ungoldman ungoldman deleted the cd-support branch September 4, 2018 19:01
@ungoldman
Copy link
Owner

📦 3.3.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants