Add $clientOptions to constructor and pass to ApiClient object #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aseveryn-hw
approved these changes
Jun 14, 2019
|
Any chance to get this merged or is there anything else that needs to be done? |
# Conflicts: # src/Hyperwallet/Hyperwallet.php
|
Hey @wmews-hw any reason this hasn't been merged yet ? |
|
Not sure why the build is failing in PHP 5.6 while passing in 7.0 and HHVM. Seems unrelated to my changes. |
specialtactics
added a commit
to specialtactics/php-sdk
that referenced
this pull request
Oct 7, 2020
|
I'd like to reference this short investigation about the failing test: |
|
I made a PR to fix the failing test here: #44 Please merge that PR, and then you can merge this. Although this PR doesn't cause any tests to fail anyway - that test just fails randomly. |
|
@Rrathinasabapath could you please look at this also? |
ghost
approved these changes
Oct 16, 2020
peter-joseph
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.