Skip to content

Conversation

specialtactics
Copy link
Contributor

Test to see if master CI tests pass

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.218% when pulling f5c4bc2 on specialtactics:chore/test into 40ef1fc on hyperwallet:master.

@specialtactics
Copy link
Contributor Author

Hi maintainers, this is to try and figure out why the test in PR #23 failed. As you can see here it fails in a different PHP version (7.3).

If you run this locally,

while (true); do ./vendor/bin/phpunit --filter=testShouldFailDecryptionWhenWrongPrivateKeyIsUsed; done

You will find it randomly fails sometimes. So it is not related to any changes in this or that pull request.

@specialtactics specialtactics changed the title test for CI [Do not merge] test for CI Oct 7, 2020
@specialtactics
Copy link
Contributor Author

I've traced the problem to this file phpseclib/phpseclib/Crypt/RSA.php and the function _rsadp whereby the $c->compare($this->modulus) > 0) condition evaluates to true.

I'm not sure why, though I would also recommend you use a much more modern library for these set of functionality, however the easiest workaround for now may be just to take into account this failure condition.

@specialtactics
Copy link
Contributor Author

Did a PR to fix it here:
#44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants