Migrate IexecPoco2#reveal unit tests #114
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #114 +/- ##
========================================
Coverage 83.75% 83.75%
========================================
Files 34 34
Lines 1077 1077
Branches 222 222
========================================
Hits 902 902
Misses 175 175 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
IexecPoco2.reveal.test.ts or IexecPoco2-reveal.test.ts ?
There was a problem hiding this comment.
I suggest to harmonize all poco test filenames when migration is completed, are you okay with that?
| ).to.be.revertedWithoutReason(); // require#5 | ||
| }); | ||
|
|
||
| it('Should not reveal when no able to prove result ownership', async () => { |
There was a problem hiding this comment.
Maybe a better way to put it, is to contribute with another worker's valid contribution (result hash and seal of worker2).
There was a problem hiding this comment.
If you want I can change
.contribute(
[...]
ethers.utils.hexZeroPad('0xbad5ea1', 32), // bad seal
[...]
)
to something like:
.contribute(
[...]
buildResultHashAndResultSeal(taskId, resultDigest, worker2).resultSeal // stolen result seal from another worker
[...]
)
?
There was a problem hiding this comment.
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
| ).to.be.revertedWithoutReason(); // require#5 | ||
| }); | ||
|
|
||
| it('Should not reveal when no able to prove result ownership', async () => { |
There was a problem hiding this comment.
| it('Should not reveal when no able to prove result ownership', async () => { | |
| it('Should not reveal when unable to prove result ownership', async () => { |
There was a problem hiding this comment.
I missed it thanks! Update test wording
No description provided.