Skip to content

Conversation

zguesmi
Copy link
Member

@zguesmi zguesmi commented Sep 9, 2024

  • // TODO: Remove header bellow
  • // TODO use IexecOrders.toArray() for spreading and remove type Orders
  • Replace some async function () by async () =>
  • Remove dynamic string keys from IexecOrders for better compilation and use @ts-ignore when needed.
  • // TODO remove these additional return values and use function toObject() for deserialization
  • Add some missing .then((tx) => tx.wait()) in Boost unit tests.

@zguesmi zguesmi self-assigned this Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.02%. Comparing base (cf15dc0) to head (f3791f7).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #123   +/-   ##
========================================
  Coverage    84.02%   84.02%           
========================================
  Files           35       35           
  Lines         1077     1077           
  Branches       201      221   +20     
========================================
  Hits           905      905           
  Misses         172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zguesmi zguesmi changed the title Clean and harmonize unit tests Clean some TODOs and harmonize unit tests Sep 10, 2024
@zguesmi zguesmi marked this pull request as ready for review September 10, 2024 08:40
Copy link
Contributor

@james-toussaint james-toussaint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zguesmi zguesmi merged commit e3291c2 into develop Sep 12, 2024
5 checks passed
@zguesmi zguesmi deleted the feature/clean-some-todos branch September 12, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants