migrate resources tests #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #125 +/- ##
========================================
Coverage 84.02% 84.02%
========================================
Files 35 35
Lines 1077 1077
Branches 201 221 +20
========================================
Hits 905 905
Misses 172 172 ☔ View full report in Codecov by Sentry. |
james-toussaint
approved these changes
Sep 13, 2024
| .setName(ensRegistry.address, newENSName) | ||
| .then((tx) => tx.wait()); | ||
|
|
||
| const nameHash = ethers.utils.namehash(`${app.address.substring(2)}.addr.reverse`); |
There was a problem hiding this comment.
You can eventually declare this function once and reuse it
There was a problem hiding this comment.
Done and factorized reused code thanks
| ).to.be.revertedWith('caller is not the owner'); | ||
| }); | ||
|
|
||
| it('Should reject invalid configuration', async () => { |
There was a problem hiding this comment.
I wonder why there is no check on _newWorkerStakeRatioPolicy 🤔
There was a problem hiding this comment.
I guess there is no upper limit for the stake.
zguesmi
reviewed
Sep 13, 2024
zguesmi
reviewed
Sep 13, 2024
zguesmi
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.