Remove smock from IexecPocoBoost unit tests
#148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-toussaint
commented
Oct 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #148 +/- ##
========================================
Coverage 84.58% 84.58%
========================================
Files 35 35
Lines 1077 1077
Branches 221 201 -20
========================================
Hits 911 911
Misses 166 166 ☔ View full report in Codecov by Sentry. |
zguesmi
approved these changes
Oct 24, 2024
| async function createFakeErc734IdentityInstance() { | ||
| return await smock.fake<IERC734>(IERC734__factory); | ||
| } | ||
| /** |
There was a problem hiding this comment.
Note for the future:
I think we can declare variables such as proxyAddress, iexecPocoBoostInstance, iexecMaintenanceAsAdmin, ... outside of the describe block to put utility functions outside and keep only init and test functions inside describe.
There was a problem hiding this comment.
See Declare variables before top describe.
Yes, not sure which form we generally prefer, but at least this form reduces diff a bit in this context 👍 !
gfournieriExec
approved these changes
Oct 24, 2024
gfournieriExec
approved these changes
Oct 24, 2024
james-toussaint
deleted the
feature/remove-smock-from-boost-unit-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.