Skip to content

Conversation

zguesmi
Copy link
Member

@zguesmi zguesmi commented Oct 23, 2024

IexecPocoDelegate.test.ts contains only 2 tests:
image

  • Sponsoring test is already implemented in IexecPoco1 tests. The latter has been updated to import missing checks.
  • Task view test has been implemented in this PR in accessors test file.

@zguesmi zguesmi self-assigned this Oct 23, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.58%. Comparing base (778b8cf) to head (67e5808).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #149   +/-   ##
========================================
  Coverage    84.58%   84.58%           
========================================
  Files           35       35           
  Lines         1077     1077           
  Branches       221      201   -20     
========================================
  Hits           911      911           
  Misses         166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zguesmi zguesmi requested review from james-toussaint, gfournieriExec and Le-Caignec and removed request for a team, james-toussaint, Le-Caignec and gfournieriExec October 25, 2024 06:57
Copy link
Contributor

@james-toussaint james-toussaint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@gfournieriExec gfournieriExec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks

Copy link
Contributor

@james-toussaint james-toussaint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zguesmi zguesmi merged commit 5749009 into develop Oct 25, 2024
5 checks passed
@zguesmi zguesmi deleted the feature/remove-smock-from-poco-delegate branch October 25, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants