Skip to content

Remove blockscout v5 refs #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Remove blockscout v5 refs #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
314ccec
remove blockscout v5 references
gfournieriExec Nov 21, 2024
1fdf806
update changelog
gfournieriExec Nov 21, 2024
5e14d0b
keep ref in sponsoring
gfournieriExec Nov 21, 2024
83d13b3
Merge branch 'develop' into fix/update-blockscout-url
gfournieriExec Nov 21, 2024
eb44d5c
back to previous v
gfournieriExec Nov 22, 2024
a1d1a98
Merge branch 'develop' into fix/update-blockscout-url
gfournieriExec Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Changelog

## vNEXT

- Remove references to blockscout v5. (#161)
- Migrate integration test files to Typescript & Hardhat:
- 000_fullchain.js (#156, #157)
- 00X_fullchain-Xworkers.js (#158, #159)
Expand Down
5 changes: 1 addition & 4 deletions hardhat.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,7 @@ import chainConfig from './config/config.json';

const isNativeChainType = chainConfig.chains.default.asset == 'Native';
const isLocalFork = process.env.LOCAL_FORK == 'true';
const bellecourBlockscoutUrl =
process.env.BLOCKSCOUT_VERSION == 'v5'
? 'https://blockscout.bellecour.iex.ec'
: 'https://blockscout-v6.bellecour.iex.ec'; // Use Blockscout v6 by default
const bellecourBlockscoutUrl = 'https://blockscout.bellecour.iex.ec';
const settings = {
optimizer: {
enabled: true,
Expand Down
7 changes: 0 additions & 7 deletions scripts/sponsoring/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,6 @@ IexecPocoAccessorsDelegate: 0xa1d371eF7bf36e89Db41276543ACf91Ec50Dd261 // https:

0b. Verify contracts

- Blockscout v5
```
BLOCKSCOUT_VERSION=v5 npx hardhat run ./scripts/sponsoring/verify.ts --network bellecour
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might remove sponsoring/verify.ts in the future, maybe we should keep it for now yes (?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep it as a second option and specify that it works with v5. We can remove BLOCKSCOUT_VERSION=v5.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept it

```

- Blockscout v6

Contracts have been verified using `etherscan-verify` plugin of `hardhat-deploy` (v0.12.4):
```
npx hardhat --network bellecour etherscan-verify
Expand Down