Fix balance checks in integration tests #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfournieriExec
changed the base branch from
develop
to
feature/migrate-200-IT
zguesmi
reviewed
Dec 10, 2024
| [ | ||
| expectedProxyBalanceChange, // Proxy | ||
| -taskPrice * completedTasks, // Requester | ||
| 0, // Requester |
| workerStakePerTask | ||
| ); | ||
| expect(finalizeTx).to.changeTokenBalances( | ||
| await expect(finalizeTx).to.changeTokenBalances( |
|
I suggest to use a clearer name for the PR: |
gfournieriExec
changed the title
zguesmi
approved these changes
Dec 10, 2024
| .then((tx) => tx.wait()); | ||
| return await extractRegistryEntryAddress(workerpoolReceipt, workerpoolRegistry.address); | ||
| } | ||
| async getInitialFrozens(accounts: SignerWithAddress[]) { |
There was a problem hiding this comment.
Suggested change
| async getInitialFrozens(accounts: SignerWithAddress[]) { | |
| async getInitialFrozens(accounts: SignerWithAddress[]) { |
test/utils/IexecWrapper.ts
Outdated
Comment on lines
472
to
475
| await IexecInterfaceNative__factory.connect( | ||
| this.proxyAddress, | ||
| ethers.provider, | ||
| ).frozenOf(this.proxyAddress) |
There was a problem hiding this comment.
Create one iexecPoco instance inside the function and re-use it.
test/utils/IexecWrapper.ts
Outdated
Comment on lines
499
to
502
| await IexecInterfaceNative__factory.connect( | ||
| this.proxyAddress, | ||
| ethers.provider, | ||
| ).frozenOf(accountsInitialFrozens[i].address) |
There was a problem hiding this comment.
Same thing, create one instance outside of the for loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.