Remove unnecessary back and forth transfers in IexecPoco2Delegate

[james-toussaint]

No description provided.

[gfournieriExec]

Do we have the same here ?

PoCo/test/byContract/IexecPoco/04_finalize.test.ts

Line 519 in d443cc4

await expect(iexecPoco.claim(kittyFillingDeal.taskId))

[james-toussaint]

Thank you very much, I screened it first then moved on since test were OK.
I found a framework issue which forces us to check token balance changes before checking events, otherwise event checking never works ..!
We need to update that in both projects in next PRs (FYI @iExecBlockchainComputing/team-blockchain)

[gfournieriExec]

Thanks for the point, we should keep in mind this !

[Le-Caignec]

Everything looks good to me. Another approach could have been to add a new function in the IExecEscrow contract named rewardAndLock().

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.68%. Comparing base (d443cc4) to head (0ac30f0).
Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #167      +/-   ##
===========================================
+ Coverage    84.67%   84.68%   +0.01%     
===========================================
  Files           35       35              
  Lines         1083     1084       +1     
  Branches       221      221              
===========================================
+ Hits           917      918       +1     
  Misses         166      166              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.