Migrate 400_contributeAndCallback.js test file to Hardhat and Typescript #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/byContract/IexecPoco/IexecPoco2-contribute-and-finalize.test.ts
Outdated
Show resolved
Hide resolved
| ).to.be.revertedWithoutReason(); // require#2 | ||
| }); | ||
|
|
||
| it('Should not contributeAndFinalize when someone else has already contributed', async () => { |
There was a problem hiding this comment.
note for later this would require a trust > 1, but that's also the require #4
Le-Caignec
reviewed
Jan 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #176 +/- ##
========================================
Coverage 84.87% 84.87%
========================================
Files 35 35
Lines 1084 1084
Branches 221 221
========================================
Hits 920 920
Misses 164 164 ☔ View full report in Codecov by Sentry. |
james-toussaint
approved these changes
Jan 10, 2025
test/byContract/IexecPoco/IexecPoco2-contribute-and-finalize.test.ts
Outdated
Show resolved
Hide resolved
gfournieriExec
approved these changes
Jan 10, 2025
james-toussaint
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.