Skip to content

Conversation

gfournieriExec
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.50%. Comparing base (46b53f5) to head (451e026).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #182   +/-   ##
========================================
  Coverage    84.50%   84.50%           
========================================
  Files           35       35           
  Lines         1084     1084           
  Branches       221      221           
========================================
  Hits           916      916           
  Misses         168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend upgrading to Ethers v6 before merging this.

@zguesmi
Copy link
Member

zguesmi commented Feb 6, 2025

@Le-Caignec
This PR brings some required cleaning to be able to migrate to newer version of HH and Ethers.
We agree, migrating to Ethers v6 is one of the next steps.

Copy link
Contributor

@james-toussaint james-toussaint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gfournieriExec gfournieriExec merged commit 7d936d4 into develop Feb 7, 2025
4 checks passed
@gfournieriExec gfournieriExec deleted the feature/replace-web3-to-ethers branch February 12, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants