Skip to content

Migrate utils/ JS files to TS #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 10, 2025
+163 −411
Merged

Migrate utils/ JS files to TS #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
61195ca
update constant file to be typed
gfournieriExec Feb 7, 2025
9f8cac9
update odb-tools in TS
gfournieriExec Feb 7, 2025
d6292ac
updtate FactoryDeployer to TS
gfournieriExec Feb 7, 2025
fc61a6f
remove useless deprecated ens deployement file
gfournieriExec Feb 7, 2025
f1efd70
keep only usefull function in EthersDeployer class
gfournieriExec Feb 7, 2025
10ac15c
update SPDX copyright years in constants and createOrders files
gfournieriExec Feb 10, 2025
762d9f3
update changelog
gfournieriExec Feb 10, 2025
a772b4a
update debug to log
gfournieriExec Feb 10, 2025
09a31f0
update to factoryConfig name
gfournieriExec Feb 10, 2025
ef91722
add todo
gfournieriExec Feb 10, 2025
f43e0a5
create ens doc
gfournieriExec Feb 10, 2025
84a700e
add addresses on ens file
gfournieriExec Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
- [x] `IexecPoco2Delegate.sol`

### Features
- Migrated utility files to TypeScript : (#183)
- `FactoryDeployer.js`, `constants.js`, `odb-tools.js`
- Removed deprecated `scripts/ens/sidechain.js`
- Purge Truffle leftovers (#180, #181, #182)
- Sunset Jenkins pipeline (#178)
- Re-use variable in `IexecPoco2Delegate` in `contribute(...)` function. (#168)
Expand Down
31 changes: 31 additions & 0 deletions docs/ENS-Addresses.md
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this file 🙏.
We can reference it in docs/README.md:

# ENS

Registered ENS names on Bellecour or Mainnet are documented in [./ENS-Addresses.md](./ENS-Addresses.md)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we can add addresses for each name?

Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# ENS Addresses in iExec PoCo

This document describes the ENS (Ethereum Name Service) addresses used in the iExec Protocol.

## Domain Structure

The iExec protocol uses the following ENS domain hierarchy:
- Root domain: `iexec.eth`
- Protocol version domain: `v5.iexec.eth`
- User domain: `users.iexec.eth`
- Resource domains:
- `apps.iexec.eth`
- `datasets.iexec.eth`
- `pools.iexec.eth`

## Core Protocol Addresses

The following ENS names are registered for core protocol components:

- `admin.iexec.eth` - Protocol administrator address
- `rlc.iexec.eth` - RLC token contract address
- `core.v5.iexec.eth` - Core protocol proxy (ERC1538Proxy)
- `0x3eca1B216A7DF1C7689aEb259fFB83ADFB894E7f`
- `apps.v5.iexec.eth` - App registry contract
- `0xB1C52075b276f87b1834919167312221d50c9D16`
- `datasets.v5.iexec.eth` - Dataset registry contract
- `0x799DAa22654128d0C64d5b79eac9283008158730`
- `workerpools.v5.iexec.eth` - Workerpool registry contract
- `0xC76A18c78B7e530A165c5683CB1aB134E21938B4`

To get more details, see [1_deploy-ens.ts script](../deploy/1_deploy-ens.ts).
3 changes: 3 additions & 0 deletions docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,6 @@

* Nominal TEE
[![Nominal TEE](https://tinyurl.com/2zubyfvw)](https://tinyurl.com/2zubyfvw)<!--![Nominal TEE](./uml/workflow-ODB-2c-match2finalize-nominal-tee.puml)-->

# ENS
Registered ENS names on Bellecour or Mainnet are documented in [./ENS-Addresses.md](./ENS-Addresses.md)
214 changes: 0 additions & 214 deletions scripts/ens/sidechain.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion test/000_fullchain-boost.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
TestClient__factory,
WorkerpoolInterface__factory,
} from '../typechain';
import constants from '../utils/constants';
import * as constants from '../utils/constants';
import {
OrdersActors,
OrdersAssets,
Expand Down
2 changes: 1 addition & 1 deletion test/byContract/IexecPoco/IexecPoco2-claim.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
getTaskId,
} from '../../../utils/poco-tools';
import { IexecWrapper } from '../../utils/IexecWrapper';
import constants from './../../../utils/constants';
import * as constants from './../../../utils/constants';

const categoryTime = 300;
const maxDealDuration = 10 * categoryTime;
Expand Down
2 changes: 1 addition & 1 deletion test/byContract/IexecPocoBoost/IexecPocoBoost.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import {
TestClient,
TestClient__factory,
} from '../../../typechain';
import constants from '../../../utils/constants';
import * as constants from '../../../utils/constants';
import {
IexecOrders,
OrdersActors,
Expand Down
Loading