Extract asset address from receipt #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-toussaint
requested review from
zguesmi,
Le-Caignec and
gfournieriExec
zguesmi
reviewed
Feb 14, 2025
| function extractEventFromReceipt( | ||
| txReceipt: ContractTransactionReceipt, | ||
| address: string, | ||
| contractInterface: Interface, |
There was a problem hiding this comment.
Just curious whether we can use just the ABI of the event (Fragment) instead of all the contract's interface.
There was a problem hiding this comment.
ABI of the event would we totally fine yes 👍
zguesmi
approved these changes
Feb 14, 2025
Le-Caignec
reviewed
Feb 14, 2025
gfournieriExec
approved these changes
Feb 17, 2025
james-toussaint
merged commit 378aac9
into
feature/migration-to-ether-v6
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.